openstack
/
watcher
Code Issues Proposed changes

Remove direct access to dbapi 

In line [1], we directly use the dbapi in order to
filter the actions by action_plan_id.

[1] https://github.com/openstack/watcher/blob/master/watcher/applier/default.py#L63

Change-Id: I2c75528f619a5277d46702cc3b4ca4bc7280f990
Closes-Bug: #1534170
This commit is contained in:
Tin Lam 2016-05-12 18:50:30 -05:00
parent bd5a969a26
commit dbdf690cd0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
watcher/applier/default.py
View File

@ -56,9 +56,7 @@ class DefaultApplier(base.BaseApplier):
def execute(self, action_plan_uuid):
LOG.debug("Executing action plan %s ", action_plan_uuid)
action_plan = objects.ActionPlan.get_by_uuid(self.context,
action_plan_uuid)
# todo(jed) remove direct access to dbapi need filter in object
filters = {'action_plan_id': action_plan.id}
actions = objects.Action.dbapi.get_action_list(self.context, filters)
filters = {'action_plan_uuid': action_plan_uuid}
actions = objects.Action.list(self.context,
filters=filters)
return self.engine.execute(actions)