opendev
/
elastic-recheck
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 34208 <34208@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 14611 \u003c14611@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Rafael Castillo replied on the change"}
This commit is contained in:
Gerrit User 34208 2022-05-18 16:31:08 +00:00 committed by Gerrit Code Review
parent 9e147dbae7
commit c90506b5ed
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
1fdc167becc193dcfd40b24eebfe2a846f3f9541 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "47ef23d5_6413f88f",
"filename": "tools/unaccounted_rechecks.py",
"patchSetId": 2
},
"lineNbr": 31,
"author": {
"id": 34208
},
"writtenOn": "2022-05-18T16:31:08Z",
"side": 0,
"message": "Changing the default to ecdsa is good, not sure about completely dropping rsa here. We should be good appending the new key type to this instead of replacing it right, right?",
"revId": "1fdc167becc193dcfd40b24eebfe2a846f3f9541",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
52978992a17586e0dbeca9bbde9af1df4c947cfa Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "78f60d9b_4b54ff5b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 34208
},
"writtenOn": "2022-05-18T16:31:08Z",
"side": 1,
"message": "Looks good, just one thing to consider.",
"revId": "52978992a17586e0dbeca9bbde9af1df4c947cfa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}