From 019d2c4dfb7351c43858b582ac32bb5e9b176c88 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Tue, 7 Jun 2011 11:47:22 -0700 Subject: [PATCH] Fix ChangeDetailFactory's invocation of PatchSetDetailFactory I flipped the order of the arguments, but did not correctly update all callers. Change-Id: Iae14ec35374342f53bc353082db35cb8750a750a Signed-off-by: Shawn O. Pearce --- .../{ReleaseNotes-2.1.7.1.txt => ReleaseNotes-2.1.7.2.txt} | 0 ReleaseNotes/index.txt | 2 +- .../gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename ReleaseNotes/{ReleaseNotes-2.1.7.1.txt => ReleaseNotes-2.1.7.2.txt} (100%) diff --git a/ReleaseNotes/ReleaseNotes-2.1.7.1.txt b/ReleaseNotes/ReleaseNotes-2.1.7.2.txt similarity index 100% rename from ReleaseNotes/ReleaseNotes-2.1.7.1.txt rename to ReleaseNotes/ReleaseNotes-2.1.7.2.txt diff --git a/ReleaseNotes/index.txt b/ReleaseNotes/index.txt index 6f020049df..d340a09018 100644 --- a/ReleaseNotes/index.txt +++ b/ReleaseNotes/index.txt @@ -4,7 +4,7 @@ Gerrit Code Review - Release Notes [[2_1]] Version 2.1.x ------------- -* link:ReleaseNotes-2.1.7.1.html[2.1.7.1], +* link:ReleaseNotes-2.1.7.2.html[2.1.7.2], * link:ReleaseNotes-2.1.7.html[2.1.7], * link:ReleaseNotes-2.1.6.html[2.1.6], link:ReleaseNotes-2.1.6.1.html[2.1.6.1] diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java index 560b1552af..40166413d7 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java @@ -194,7 +194,7 @@ public class ChangeDetailFactory extends Handler { NoSuchEntityException, PatchSetInfoNotAvailableException, NoSuchChangeException { final PatchSet.Id psId = detail.getChange().currentPatchSetId(); - final PatchSetDetailFactory loader = patchSetDetail.create(psId, null, null); + final PatchSetDetailFactory loader = patchSetDetail.create(null, psId, null); loader.patchSet = detail.getCurrentPatchSet(); loader.control = control; detail.setCurrentPatchSetDetail(loader.call());