opendev
/
gerrit
Code Issues Proposed changes

Do not reset Patch History selection on navigation to next file diff 

When the user views a file diff and then changes in the Patch History
the selection of side A (left side), then this selection is lost when
the user navigates to the previous or next file diff. The selection of
side A is always reset to the patch set that is selected as 'Old
Version History' on the ChangeScreen (the base for comparing patch
sets).

This change ensures that the selection in the Patch History is kept
when the user navigates to the previous or next file diff.

Bug: issue 999
Change-Id: I19cafedd8a11683dca4a24fbebbcacf63425fe62
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin 2011-06-03 13:11:46 +02:00
parent e43d3c4669
commit c82e9e98b6
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
View File

@ -479,6 +479,9 @@ public abstract class PatchScreen extends Screen implements
public void setSideA(PatchSet.Id patchSetId) {
idSideA = patchSetId;
diffSideA = patchSetId;
if (fileList != null) {
fileList.setPatchSetIdToCompareWith(patchSetId);
}
}
public void setSideB(PatchSet.Id patchSetId) {