gerrit/gerrit-gwtui
Marco Miller c2114ac086 ProjectTagsScreen: Base visibility on the create refs/tags/* permission
Before this change, the Tags creation form fields were visible also if
either refs/* or refs/head/* was allowed for Create Reference. This fix
limits that visibility to a create refs/tags/* permission solely, as per
current documentation anyway. isAdmin() still also makes the panel
visible, overriding potentially missing ref creation permissions.

Create Annotated Tag is still also required for the user to be able to
use the optional Annotation field. In this case, the created tag is no
longer lightweight but becomes annotated. Both kinds of tags are still
supported through such a single Tags creation panel or form, thus the
need to allow both permissions even if aiming for annotated tags only.
(Command line does not have that design limitation indeed.)

Bug: Issue 9689
Change-Id: Ib7c3f1a0fdebaee30da371cc64850fa6d6d8dd05
2018-09-10 17:12:40 -04:00
..
src ProjectTagsScreen: Base visibility on the create refs/tags/* permission 2018-09-10 17:12:40 -04:00
BUILD Merge branch 'stable-2.14' into stable-2.15 2018-06-14 16:55:29 +09:00