fc9d1ae55f
Setting to NOTE_DB means new changes will never be written to ReviewDb. Update ChangeNotes.Factory to properly detect the case of a change not existing in ReviewDb but possibly still existing in NoteDb. This config option only controls the primary storage for new changes. Old changes (that have not been migrated, which is all of them since this change predates the migration tools) keep their primary storage as REVIEW_DB. This means that a single running server needs to be able to handle a mix of NOTE_DB/REVIEW_DB changes. Thus we need to continue using a live ReviewDb instance in the server, and just avoid writing any NoteDb-primary changes to that instance. The easiest way to implement this technically is to keep all the BatchUpdate code the same but only commit the change transaction if the change requires ReviewDb. This means we don't have to change any BatchUpdate.Op implementations, they can continue unconditionally writing. Rolling back the transaction is much simpler than creating some kind of ReviewDb wrapper that drops writes on the floor, even though it does technically create some database traffic even though no writes are committed. Add a new NoteDbMode to run all tests with this option enabled, double-checking after the tests that no changes were stored in ReviewDb. Tweak tests in various ways to work with this option enabled, avoiding direct use of ReviewDb when the primary storage is NoteDb. Change-Id: I9caf13192f955c4ec90409da32609d0a6f496d96 |
||
|---|---|---|
| .. | ||
| AbstractPushForReview.java | ||
| AbstractSubmoduleSubscription.java | ||
| BUCK | ||
| BUILD | ||
| DraftChangeBlockedIT.java | ||
| ForcePushIT.java | ||
| HttpPushForReviewIT.java | ||
| ImplicitMergeCheckIT.java | ||
| RefAdvertisementIT.java | ||
| SshPushForReviewIT.java | ||
| SubmitOnPushIT.java | ||
| SubmoduleSectionParserIT.java | ||
| SubmoduleSubscriptionsIT.java | ||
| SubmoduleSubscriptionsWholeTopicMergeIT.java | ||