opendev
/
git-restack
Code Issues Proposed changes

git review -sv gets more verbose 

Sometimes it's difficult to understand reason
why git review -s failed since error description
in code is not streamed to stdout.

Change-Id: I59c0deef5f32d10f9e3e7c50dbaffc6a9f59a466
Closes-Bug: #2000234
This commit is contained in:
Dmitry Ratushnyy 2015-04-09 19:45:12 +03:00
parent 79262a5230
commit fbdff3245e
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
git_review/cmd.py
View File

@ -331,7 +331,7 @@ def set_hooks_commit_msg(remote, target_file):
if VERBOSE:
hook_url = 'scp://%s%s/hooks/commit-msg' \
% (userhost, (":%s" % port) if port else "")
% (userhost, (":%s" % port) if port else "")
print("Fetching commit hook from: %s" % hook_url)
run_command_exc(CannotInstallHook, *cmd)
@ -341,15 +341,16 @@ def set_hooks_commit_msg(remote, target_file):
def test_remote_url(remote_url):
"""Tests that a possible gerrit remote url works."""
status, __ = run_command_status("git", "push", "--dry-run", remote_url,
"--all")
status, description = run_command_status("git", "push", "--dry-run",
remote_url, "--all")
if status != 128:
if VERBOSE:
print("%s worked." % remote_url)
print("%s worked. Description: %s" % (remote_url, description))
return True
else:
if VERBOSE:
print("%s did not work." % remote_url)
print("%s did not work. Description: %s" % (
remote_url, description))
return False