opendev
/
git-review
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+2

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 6c4f57ea367d4863a8be9949e77ecfcfc049a1f4
Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2023-08-16 13:04:34 +00:00 committed by Gerrit Code Review
parent 25f4386a2c
commit 4f7720b4ff
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
21d9ceb5a556009b902db32944cd970c079024e4
View File

@ -16,6 +16,23 @@
"message": "Thanks for updating, I was just about to do it.",
"revId": "21d9ceb5a556009b902db32944cd970c079024e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e3a6e4af_da883a9e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2023-08-16T13:04:34Z",
"side": 1,
"message": "thx",
"revId": "21d9ceb5a556009b902db32944cd970c079024e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
fc1b823bc4bbb45e9cd03c1430035a4524137f53
View File

@ -50,6 +50,24 @@
"message": "ssh \u003d os.environ.get(\"GIT_SSH\", \"ssh\") would seem more pythonic to me, just a single statement instead of three lines",
"revId": "fc1b823bc4bbb45e9cd03c1430035a4524137f53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "11fd2865_bf248db8",
"filename": "git_review/cmd.py",
"patchSetId": 1
},
"lineNbr": 721,
"author": {
"id": 13252
},
"writtenOn": "2023-08-16T13:04:34Z",
"side": 1,
"message": "Done",
"parentUuid": "811b7d0b_2ad9f7cf",
"revId": "fc1b823bc4bbb45e9cd03c1430035a4524137f53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}