opendev
/
git-review
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+2

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, ad0fd866c9781ed26566fc6b17c96f54b453afc6
This commit is contained in:
Gerrit User 13252 2023-08-16 12:29:06 +00:00 committed by Gerrit Code Review
parent f020953ad7
commit 5994f85ead
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
fc1b823bc4bbb45e9cd03c1430035a4524137f53
View File

@ -16,6 +16,40 @@
"message": "Is there something I should do now for this patch to be merged?",
"revId": "fc1b823bc4bbb45e9cd03c1430035a4524137f53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "59fae670_22655d12",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2023-08-16T12:29:06Z",
"side": 1,
"message": "I don\u0027t want to block this, but I think it could also be improved",
"revId": "fc1b823bc4bbb45e9cd03c1430035a4524137f53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "811b7d0b_2ad9f7cf",
"filename": "git_review/cmd.py",
"patchSetId": 1
},
"lineNbr": 721,
"author": {
"id": 13252
},
"writtenOn": "2023-08-16T12:29:06Z",
"side": 1,
"message": "ssh \u003d os.environ.get(\"GIT_SSH\", \"ssh\") would seem more pythonic to me, just a single statement instead of three lines",
"revId": "fc1b823bc4bbb45e9cd03c1430035a4524137f53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}