opendev
/
git-review
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
This commit is contained in:
Gerrit User 5263 2024-03-05 22:01:44 +00:00 committed by Gerrit Code Review
parent 01e804c754
commit f142c67505
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
e54d324370187039eb3cc9899d480ab70be58714
View File

@ -51,6 +51,24 @@
"revId": "e54d324370187039eb3cc9899d480ab70be58714",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3ce9b918_5f005d19",
"filename": "git_review/cmd.py",
"patchSetId": 3
},
"lineNbr": 990,
"author": {
"id": 5263
},
"writtenOn": "2024-03-05T22:01:44Z",
"side": 1,
"message": "Done.",
"parentUuid": "508381ea_4b8c2ca5",
"revId": "e54d324370187039eb3cc9899d480ab70be58714",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -67,6 +85,42 @@
"message": "Would be good to have this test check the git rebase state after running git review. Also adding a new test for the -K flag to check that the rebase is not aborted. Basically a new test that is a small variant of this existing test.",
"revId": "e54d324370187039eb3cc9899d480ab70be58714",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8f0f7ebe_fd43b0f6",
"filename": "git_review/tests/test_git_review.py",
"patchSetId": 3
},
"lineNbr": 332,
"author": {
"id": 5263
},
"writtenOn": "2024-03-05T22:01:44Z",
"side": 1,
"message": "Done.",
"parentUuid": "fbb7bb8f_3b881738",
"revId": "e54d324370187039eb3cc9899d480ab70be58714",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "455e0d15_b5d6106c",
"filename": "git_review/tests/test_git_review.py",
"patchSetId": 3
},
"lineNbr": 332,
"author": {
"id": 5263
},
"writtenOn": "2024-03-05T22:01:44Z",
"side": 1,
"message": "Done.",
"parentUuid": "fbb7bb8f_3b881738",
"revId": "e54d324370187039eb3cc9899d480ab70be58714",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}