opendev
/
puppet-ciwatch
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(9 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 7979 2015-12-04 01:01:52 +00:00 committed by Gerrit Code Review
parent 3290c8d545
commit 496bb0198b
1 changed files with 161 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

161
5369915076214f4ad0a415dfb6cf41bbee64df4d
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_cd108c51",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "Done",
"parentUuid": "7a740942_1c5fac73",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_5ccc5435",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_6d1dd865",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 46,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "Done",
"parentUuid": "7a740942_5ccc5435",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_f71f5959",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_2d26f0ba",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 62,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "The only reason this variable exists is because it is used in the config template. I\u0027ll move it down so it is closer to that place and would be less confusing.",
"parentUuid": "7a740942_f71f5959",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_dc8604b9",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_2d9590e3",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 103,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "Done",
"parentUuid": "7a740942_dc8604b9",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_170ea534",
@ -85,6 +157,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_1749c58b",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 139,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "That is intentional, puppet \u003e 2.7 autorequires all file parents.",
"parentUuid": "7a740942_170ea534",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_57ee6d23",
@ -102,6 +192,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_32bc0f6c",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 153,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "It creates initd service file, which would not fail even if ciwatch is not installed yet. So there is no need to enforce ordering as it is now. We would want ordering if we used \u0027ensure \u003d\u003e running\u0027. I\u0027ll add it in just to be safe.",
"parentUuid": "7a740942_57ee6d23",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_17f8e5e4",
@ -119,6 +227,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_b20c7f43",
"filename": "manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 175,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "ciwatch logging handles rogrotation in-code, no need to setup logrotate here. Would remove.",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_573c2d93",
@ -136,6 +261,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_6d063822",
"filename": "manifests/initd_service.pp",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "\"title\" would be a bad variable name to use in the templates. Also confusing if people would try to figure out where it came from.",
"parentUuid": "7a740942_573c2d93",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_97aa956f",
@ -152,6 +295,24 @@
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_684b865a",
"filename": "templates/ciwatch_service.init.erb",
"patchSetId": 5
},
"lineNbr": 144,
"author": {
"id": 7979
},
"writtenOn": "2015-12-04T01:01:52Z",
"side": 1,
"message": "Removed inconsistencies.",
"parentUuid": "7a740942_97aa956f",
"revId": "5369915076214f4ad0a415dfb6cf41bbee64df4d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}