opendev
/
puppet-ciwatch
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review+1

(2 comments)

Patch-set: 9
Label: Code-Review=+1
This commit is contained in:
Gerrit User 1106 2016-04-04 21:58:11 +00:00 committed by Gerrit Code Review
parent 6c31720500
commit 955a770d10
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
4b4d989094d112fcd360d17de9f882d2b9a2d518
View File

@ -35,6 +35,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a061dce_eb73d04b",
"filename": "manifests/init.pp",
"patchSetId": 9
},
"lineNbr": 74,
"author": {
"id": 1106
},
"writtenOn": "2016-04-04T21:58:11Z",
"side": 1,
"message": "It is not, it was a suggestion.\nThe -1 was not due to this.",
"parentUuid": "9a061dce_ff81ce90",
"revId": "4b4d989094d112fcd360d17de9f882d2b9a2d518",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a061dce_06574403",
@ -69,6 +87,24 @@
"revId": "4b4d989094d112fcd360d17de9f882d2b9a2d518",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a061dce_ebc11030",
"filename": "manifests/init.pp",
"patchSetId": 9
},
"lineNbr": 137,
"author": {
"id": 1106
},
"writtenOn": "2016-04-04T21:58:11Z",
"side": 1,
"message": "You are right, I read docs and files containing folder managed by puppet are autorequired, thus pulling the -1 (even though I prefer explicit over implicit).\n\nThanks",
"parentUuid": "9a061dce_bfe75611",
"revId": "4b4d989094d112fcd360d17de9f882d2b9a2d518",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}