opendev
/
puppet-ethercalc
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Label: Code-Review=-1
This commit is contained in:
Gerrit User 4146 2018-08-10 17:44:42 +00:00 committed by Gerrit Code Review
parent 0972ddbf08
commit 70faff67fa
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
0d38944e1ffbac6157e9dee113e2f8bbc10df08e Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_df0b657a",
"filename": "manifests/init.pp",
"patchSetId": 3
},
"lineNbr": 116,
"author": {
"id": 4146
},
"writtenOn": "2018-08-10T17:44:42Z",
"side": 1,
"message": "I don\u0027t think this symlink will work with our existing install.\n\n clarkb@ethercalc01:~$ ls -l /opt/ethercalc/node_modules/ethercalc/node_modules\n total 52\n drwxr-xr-x 5 root root 4096 Feb 14 2017 cors\n drwxr-xr-x 6 root root 4096 Feb 14 2017 csv-parse\n drwxr-xr-x 4 root root 4096 Feb 14 2017 iconv-lite\n drwxr-xr-x 4 root root 4096 Feb 14 2017 j\n drwxr-xr-x 5 root root 4096 Feb 14 2017 livescript\n drwxr-xr-x 3 root root 4096 Feb 14 2017 minimatch\n drwxr-xr-x 4 root root 4096 Feb 14 2017 nodemailer\n drwxr-xr-x 5 root root 4096 Feb 14 2017 optimist\n drwxr-xr-x 3 root root 4096 Feb 14 2017 redis\n drwxr-xr-x 3 root root 4096 Feb 14 2017 socialcalc\n drwxr-xr-x 3 root root 4096 Feb 14 2017 uuid-pure\n drwxr-xr-x 4 root root 4096 Feb 14 2017 xoauth2\n drwxr-xr-x 5 root root 4096 Feb 14 2017 zappajs\n clarkb@ethercalc01:~$ ls -l /opt/ethercalc/node_modules/\n total 4\n drwxr-xr-x 16 root root 4096 Feb 14 2017 ethercalc\n\nWe will end up targeting a directory that doesn\u0027t exist. Can we turn this into a conditional that adds the symlink if /opt/ethercalc/node_modules/ethercalc/node_modules/socialcalc does not exist? Maybe using an exec with an onlyif?",
"revId": "0d38944e1ffbac6157e9dee113e2f8bbc10df08e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}