opendev
/
puppet-gerrit
Code Issues Proposed changes

fix its_rules parameterization in template 

The 'event-type' reference should be 'event_type' instead.
Also fixed a bug in the documentation and subsequent beaker test.

Change-Id: I4802f49e1fb1d3210aa49b4fe12a6e33a9f3bd42
This commit is contained in:
Khai Do 2016-08-04 10:55:37 -07:00
parent 53ec1731cc
commit 188e34af98
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/init.pp
View File

@ -86,9 +86,9 @@
# 'name' => 'approval-Code-Review', # 'name' => 'approval-Code-Review',
# 'approvals' => '-2, -1', # 'approvals' => '-2, -1',
# }, # },
# ] # ],
# }, # },
# ] # ],
# #
# trackingids: # trackingids:
# A list of regexes to reference external tracking systems. # A list of regexes to reference external tracking systems.

4
spec/acceptance/fixtures/default.pp
View File

@ -57,9 +57,9 @@ class { '::gerrit':
'name' => 'approval-Code-Review', 'name' => 'approval-Code-Review',
'approvals' => '-2, -1', 'approvals' => '-2, -1',
}, },
] ],
}, },
] ],
} }
class { '::gerrit::cron': } class { '::gerrit::cron': }

2
templates/gerrit.its_rules.erb
View File

@ -1,7 +1,7 @@
<% @its_rules.each do |its_rule| -%> <% @its_rules.each do |its_rule| -%>
[rule "<%= its_rule['name'] %>"] [rule "<%= its_rule['name'] %>"]
action = <%= its_rule['action'] %> action = <%= its_rule['action'] %>
<% unless its_rule['event-type'].nil? -%> <% unless its_rule['event_type'].nil? -%>
event-type = <%= its_rule['event_type'] %> event-type = <%= its_rule['event_type'] %>
<% end -%> <% end -%>
<% unless its_rule['label'].nil? -%> <% unless its_rule['label'].nil? -%>