Update patch set 6

Patch Set 6: Code-Review-1

(4 comments)

-1 because it isn't clear what happens when you have a series of sideloaded rules with the same precedence. What order is used? At the very least we should document what happens to avoid surprises.

Patch-set: 6
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

d8e1e56916fff039bd519e72c8f295b6c1f5c9a9

@@ -0,0 +1,72 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "fa1b9901_d82c5fae",
+        "filename": "manifests/init.pp",
+        "patchSetId": 6
+      },
+      "lineNbr": 81,
+      "author": {
+        "id": 4146
+      },
+      "writtenOn": "2015-08-25T18:39:16Z",
+      "side": 1,
+      "message": "The new side loaded rules come after these rules and before the udp rules below. We should probably colocate the tcp rules and colocate the udp rules and colocate the raw passthrough to keep the resulting sets sane.\n\nAs an alternative maybe put all the sideloaded stuff after the defaults that were preexisting.",
+      "revId": "d8e1e56916fff039bd519e72c8f295b6c1f5c9a9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa1b9901_f87b63bc",
+        "filename": "manifests/rules.pp",
+        "patchSetId": 6
+      },
+      "lineNbr": 16,
+      "author": {
+        "id": 4146
+      },
+      "writtenOn": "2015-08-25T18:39:16Z",
+      "side": 1,
+      "message": "See corresponding comment for tcp.",
+      "revId": "d8e1e56916fff039bd519e72c8f295b6c1f5c9a9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa1b9901_18b2d794",
+        "filename": "manifests/tcp_allow.pp",
+        "patchSetId": 6
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 4146
+      },
+      "writtenOn": "2015-08-25T18:39:16Z",
+      "side": 1,
+      "message": "How does concat resolve multiple fragments with the same order value? this will be important to understand if you have \u003e1 rule and order matters.",
+      "revId": "d8e1e56916fff039bd519e72c8f295b6c1f5c9a9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa1b9901_b8696bfb",
+        "filename": "manifests/udp_allow.pp",
+        "patchSetId": 6
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 4146
+      },
+      "writtenOn": "2015-08-25T18:39:16Z",
+      "side": 1,
+      "message": "See corresponding comment for tcp rules.",
+      "revId": "d8e1e56916fff039bd519e72c8f295b6c1f5c9a9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}