From 8cfec53993f8e6687dcc7522edae8e10da734b10 Mon Sep 17 00:00:00 2001
From: Jeremy Stanley <fungi@yuggoth.org>
Date: Fri, 9 Aug 2019 23:48:24 +0000
Subject: [PATCH] Put image data in a parallel path to source code

To avoid co-mingling configuration-managed files with state data,
place them in parallel paths so that the latter can be mounted from
an external volume.

Change-Id: Ibfedb88bbcf7c816b200b978c987a7c2f3e9f0d4
---
 manifests/init.pp          | 11 ++++++++++-
 templates/Settings.php.erb |  2 +-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/manifests/init.pp b/manifests/init.pp
index ad7b646..3836c24 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -2,7 +2,7 @@
 #
 class mediawiki(
   $mediawiki_location         = '/srv/mediawiki/w',
-  $mediawiki_images_location  = '/srv/mediawiki/images',
+  $mediawiki_images_location  = '/srv/mediawiki-data/images',
   $role                       = 'all',
   $site_hostname              = $::fqdn,
   $serveradmin                = "webmaster@${::fqdn}",
@@ -39,6 +39,15 @@ class mediawiki(
       ensure => directory,
     }
 
+    file { '/srv/mediawiki-data':
+      ensure => directory,
+    }
+
+    file { $mediawiki_images_location:
+      ensure  => directory,
+      require => File['/srv/mediawiki-data'],
+    }
+
     file { '/srv/mediawiki/Settings.php':
       ensure  => file,
       content => template('mediawiki/Settings.php.erb'),
diff --git a/templates/Settings.php.erb b/templates/Settings.php.erb
index 82f8e9c..c5fe4b9 100644
--- a/templates/Settings.php.erb
+++ b/templates/Settings.php.erb
@@ -106,7 +106,7 @@ $wgAllowUserJs = true;
 $wgEnableUploads  = false;
 $wgUseImageMagick = true;
 $wgImageMagickConvertCommand = "/usr/bin/convert";
-$wgUploadDirectory = "/srv/mediawiki/images";
+$wgUploadDirectory = "<%= @mediawiki_images_location %>";
 $wgFileExtensions[] = 'svg';
 
 # InstantCommons allows wiki to use images from http://commons.wikimedia.org