openinfra
/
interop
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(4 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 7160 \u003c7160@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_22873\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 22873 \u003c22873@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_22873\u003e replied on the change"}
This commit is contained in:
Gerrit User 22873 2022-10-21 18:40:44 +00:00 committed by Gerrit Code Review
parent b66727fd7d
commit 6c19ff8560
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
b18cd2fa852f2630aaf041608dbac74ff8e9e2b8
View File

@ -57,6 +57,30 @@
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "221996a3_b7d20028",
"filename": "add-ons/guidelines/key_manager.next.json",
"patchSetId": 2
},
"lineNbr": 58,
"author": {
"id": 22873
},
"writtenOn": "2022-10-21T18:40:44Z",
"side": 1,
"message": "it should be this one (2022.11), when I drafted the patch I didn\u0027t know how exactly we were gonna proceed, but we made it clear during the PTG",
"parentUuid": "31ba94a8_3710d872",
"range": {
"startLine": 58,
"startChar": 38,
"endLine": 58,
"endChar": 45
},
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -104,6 +128,30 @@
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "656abc94_fcfe8624",
"filename": "add-ons/guidelines/key_manager.next.json",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 22873
},
"writtenOn": "2022-10-21T18:40:44Z",
"side": 1,
"message": "in the discussion on line 58 we decided to use 2022.11 - this \"replaces\" field should contain previous guideline;\n\ne.g. 2022.06 guideline replaces 2021.11 one:\nhttps://opendev.org/openinfra/interop/src/commit/e55a7d6938d3f06a0bf421c5f8533e2f73236bcf/guidelines/2022.06.json#L73-L74\n\nHowever, key_manager doesn\u0027t have any previous guideline, well, it does, next, but is that what we wanna use here? \n\nI see 3 options:\n1. \"\" - empty as there is no previous release of this guideline\n2. \"next\" - next, as that\u0027s the current release of this guideline\n3. \"2022.06\" - 2022.06 as that\u0027s a previous guideline release in general (not a release of this guideline, but the release of other guidelines - addons + platform)",
"parentUuid": "7b9b6eec_5be6b009",
"range": {
"startLine": 59,
"startChar": 17,
"endLine": 59,
"endChar": 21
},
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -151,6 +199,30 @@
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "75a2596b_fa100be2",
"filename": "add-ons/guidelines/load_balancer.next.json",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 22873
},
"writtenOn": "2022-10-21T18:40:44Z",
"side": 1,
"message": "Done",
"parentUuid": "c19bbe5f_65867633",
"range": {
"startLine": 59,
"startChar": 6,
"endLine": 59,
"endChar": 21
},
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -173,6 +245,30 @@
},
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "81d6ae4f_3c7c1047",
"filename": "add-ons/guidelines/orchestration.next.json",
"patchSetId": 2
},
"lineNbr": 58,
"author": {
"id": 22873
},
"writtenOn": "2022-10-21T18:40:44Z",
"side": 1,
"message": "Ack",
"parentUuid": "7c8abc03_ed6f86ee",
"range": {
"startLine": 58,
"startChar": 0,
"endLine": 58,
"endChar": 49
},
"revId": "b18cd2fa852f2630aaf041608dbac74ff8e9e2b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}