Update patch set 1
Patch Set 1: I would prefer that you didn't merge this (2 inline comments) Please see https://review.openstack.org/#/c/53090/ for why POST is used instead of DELETE. The editorial changes seem fine and are probably better than the original intent of describing the output of bulk operations in one place. Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
fd4030806b
commit
34cef24777
|
@ -0,0 +1,38 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAWH//XZM\u003d",
|
||||
"filename": "openstack-object-storage-dev/section_object-api-bulk-delete.xml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 17,
|
||||
"author": {
|
||||
"id": 860
|
||||
},
|
||||
"writtenOn": "2014-03-18T10:59:59Z",
|
||||
"side": 1,
|
||||
"message": "While I understand that the text \"you can configure the maximum number of items value\" was is the original text, it does not make sense for a user of the API because:\n\na/ there is no \"maximum number of items\" parameter in the API operation itself\n\nb/ The 10,000 value is configurable my the admin -- not the end user of the API..\n\nI suggest you:\n\n- Add the \"(configurable)\" after the 10,000\n- Delete the sentence \"You can configure the maximum number of items value.\"",
|
||||
"revId": "97b88455b18bf92df7d48b3b9372cbe1a08f480a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAWH//XY0\u003d",
|
||||
"filename": "openstack-object-storage-dev/section_object-api-bulk-delete.xml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 860
|
||||
},
|
||||
"writtenOn": "2014-03-18T10:59:59Z",
|
||||
"side": 1,
|
||||
"message": "The operation POST or DELETE, is no longer mentioned.",
|
||||
"revId": "97b88455b18bf92df7d48b3b9372cbe1a08f480a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue