openstack
/
ansible-role-systemd_networkd
Code Issues Proposed changes

Fix linter errors and update tests 

This patch fixes linter errors, updates tests, and adds the MTUBytes
interface configuration option to the systemd .network file to support
live MTU changes upon restart of systemd-networkd. Without it, MTU
changes will only be effective upon boot (might only affect Focal).

Change-Id: I05da4036b0ddc3fb88ba958f413a32fa6819de61
This commit is contained in:
Jonathan Rosser 2020-10-06 10:42:36 +01:00 committed by James Denton
parent 438e946a06
commit 6b1c9e95b6
3 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/conf.py
View File

@ -231,7 +231,7 @@ latex_elements = {
# author, documentclass [howto, manual, or own class]).
latex_documents = [
(master_doc, 'doc-' + target_name + '.tex',
title.replace("_", "\_"), author, 'manual'),
title.replace("_", r"\_"), author, 'manual'),
]
latex_use_xindy = False

5
templates/systemd-network.j2
View File

@ -58,3 +58,8 @@ VXLAN={{ item.1.vxlan }}
{% if item.1.ipforward is defined %}
IPForward={{ (item.1.ipforward | bool) | ternary('yes', 'no') }}
{% endif %}
[Link]
{% if item.1.mtu is defined %}
MTUBytes={{ item.1.mtu }}
{% endif %}

16
tests/test.yml
View File

@ -101,31 +101,31 @@
- name: Interface check
assert:
that:
- ansible_dummy0['active'] == true
- ansible_dummy0['active']
- ansible_dummy0['type'] == 'ether'
- ansible_dummy0['mtu'] == 9000
- ansible_dummy1['active'] == true
- ansible_dummy1['active']
- ansible_dummy1['type'] == 'ether'
- ansible_dummy1['mtu'] == 9000
- ansible_dummy2['active'] == true
- ansible_dummy2['active']
- ansible_dummy2['type'] == 'ether'
- name: Bond check
assert:
that:
- ansible_bond0['active'] == true
- ansible_bond0['active']
- ansible_bond0['type'] == 'bonding'
- ansible_bond0['mtu'] == 9000
- name: Bridge check
assert:
that:
- ansible_br_dummy['active'] == true
- ansible_br_dummy['active']
- ansible_br_dummy['type'] == 'bridge'
- ansible_br_dummy['ipv4']['address'] == '10.0.0.100'
- ansible_br_dummy['ipv4']['netmask'] == '255.255.255.0'
- name: Bridge check
assert:
that:
- ansible_br_test['active'] == true
- ansible_br_test['active']
- ansible_br_test['type'] == 'bridge'
- ansible_br_test['ipv4']['address'] == '10.1.0.1'
- ansible_br_test['ipv4']['netmask'] == '255.255.255.0'
@ -159,12 +159,12 @@
assert:
that:
- ansible_br_test is defined
- ansible_dummy2['active'] == true
- ansible_dummy2['active']
- ansible_dummy2['type'] == 'ether'
- name: Bridge check
assert:
that:
- ansible_br_test['active'] == true
- ansible_br_test['active']
- ansible_br_test['type'] == 'bridge'
- ansible_br_test['ipv4']['address'] == '10.1.0.1'
- ansible_br_test['ipv4']['netmask'] == '255.255.255.0'