From 8eeff8d03ee8554c0b476ffd83367f4498ae2b8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Douglas=20Mendiz=C3=A1bal?= Date: Thu, 31 Jan 2019 17:03:09 -0600 Subject: [PATCH] Fix secret-stores functional tests This patch fixes some broken tests that were incorrectly looking for a "secret-stores" key in API responses. The correct key is "secret_stores". Change-Id: Ia42d14a1163f53d220e243ae0ecd5138e278db14 --- functionaltests/api/v1/functional/test_secrets.py | 2 +- functionaltests/api/v1/functional/test_secretstores.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/functionaltests/api/v1/functional/test_secrets.py b/functionaltests/api/v1/functional/test_secrets.py index 8034d0a18..35f2dc942 100644 --- a/functionaltests/api/v1/functional/test_secrets.py +++ b/functionaltests/api/v1/functional/test_secrets.py @@ -1613,7 +1613,7 @@ class SecretsMultipleBackendTestCase(base.TestCase): user_name=admin_a) self.assertEqual(200, resp.status_code) secret_store_ref = None - for store in stores['secret-stores']: + for store in stores['secret_stores']: if not store['global_default']: secret_store_ref = store['secret_store_ref'] break diff --git a/functionaltests/api/v1/functional/test_secretstores.py b/functionaltests/api/v1/functional/test_secretstores.py index 4788654ab..a45aba1ab 100644 --- a/functionaltests/api/v1/functional/test_secretstores.py +++ b/functionaltests/api/v1/functional/test_secretstores.py @@ -78,8 +78,8 @@ class SecretStoresTestCase(base.TestCase): self.assertEqual(expected_return, resp.status_code) if expected_return == 200: - self.assertIsNotNone(json_data['secret-stores']) - stores = json_data['secret-stores'] + self.assertIsNotNone(json_data.get('secret_stores')) + stores = json_data['secret_stores'] for secret_store in stores: self._validate_secret_store_fields(secret_store) @@ -125,7 +125,7 @@ class SecretStoresTestCase(base.TestCase): user_name=admin_a) self.assertEqual(200, resp.status_code) - stores = json_data['secret-stores'] + stores = json_data['secret_stores'] store = stores[len(stores)-1] secret_store_ref = store['secret_store_ref'] @@ -191,7 +191,7 @@ class SecretStoresTestCase(base.TestCase): user_name=admin_a) self.assertEqual(200, resp.status_code) - stores = json_data['secret-stores'] + stores = json_data['secret_stores'] store = stores[len(stores)-1] secret_store_ref = store['secret_store_ref']