From a28ae917bc419ce53823c944f6894c7652c4851c Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Wed, 20 Sep 2023 17:05:53 +0100 Subject: [PATCH] ironic: Perform online data migrations with localhost DB Previously online data migrations were not performed in the default configuration where the database address is 'localhost'. I'm not sure why this condition was used, but it was present in the original change I685efd14bf3567a126311b676a50b0abb0f043db submitted adding the online data migrations back in the Stein release. This change removes the condition to perform online data migrations regardless of the database address. Change-Id: I60d0f61a3c6fd3573b2031f7dba5d8a29e178394 Closes-Bug: #2036772 (cherry picked from commit d656492d4b386864a28042f3c2797a4891ba6252) --- .../roles/bifrost-ironic-install/tasks/migrations.yml | 1 - .../notes/online-data-migrations2-b86dff53f42718f5.yaml | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/online-data-migrations2-b86dff53f42718f5.yaml diff --git a/playbooks/roles/bifrost-ironic-install/tasks/migrations.yml b/playbooks/roles/bifrost-ironic-install/tasks/migrations.yml index c161374ce..284d78c16 100644 --- a/playbooks/roles/bifrost-ironic-install/tasks/migrations.yml +++ b/playbooks/roles/bifrost-ironic-install/tasks/migrations.yml @@ -14,4 +14,3 @@ - name: "Perform ironic online data migrations" command: ironic-dbsync --config-file /etc/ironic/ironic.conf online_data_migrations environment: "{{ bifrost_venv_env }}" - when: ironic.database.host != 'localhost' diff --git a/releasenotes/notes/online-data-migrations2-b86dff53f42718f5.yaml b/releasenotes/notes/online-data-migrations2-b86dff53f42718f5.yaml new file mode 100644 index 000000000..510ef7781 --- /dev/null +++ b/releasenotes/notes/online-data-migrations2-b86dff53f42718f5.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + Fixes an issue where online data migrations were not performed in the + default Bifrost configuration where ``localhost`` is used as the database + address. See `LP#2036772 + `__ for details.