openstack
/
ceilometermiddleware
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_5202\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 5202 \u003c5202@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_5202\u003e replied on the change"}
This commit is contained in:
Gerrit User 5202 2024-04-18 09:11:53 +00:00 committed by Gerrit Code Review
parent f5b8278423
commit 46927a3301
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
0c5de2df506507e89e764a0e36cdcd2d9dde09a4 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1161ed81_a533fc28",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 5202
},
"writtenOn": "2024-04-18T09:11:53Z",
"side": 1,
"message": "Just question about the error handling, otherwise looks good to me.",
"revId": "0c5de2df506507e89e764a0e36cdcd2d9dde09a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b8effce3_3139881e",
"filename": "ceilometermiddleware/swift.py",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 5202
},
"writtenOn": "2024-04-18T09:11:53Z",
"side": 1,
"message": "Shouldn\u0027t we log that and let the operator know that we couldn\u0027t apply their extra configs?",
"revId": "0c5de2df506507e89e764a0e36cdcd2d9dde09a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}