openstack
/
ceilometermiddleware
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 15343 \u003c15343@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_29541\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 29541 \u003c29541@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_29541\u003e replied on the change"}
This commit is contained in:
Gerrit User 29541 2023-11-02 11:44:13 +00:00 committed by Gerrit Code Review
parent c0d026024d
commit d6b499c541
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
14d324d9289f77fdf68e8e8a543d4f3caaf7f734
View File

@ -23,6 +23,30 @@
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "73740726_06c9a9f0",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 9,
"author": {
"id": 29541
},
"writtenOn": "2023-11-02T11:44:13Z",
"side": 1,
"message": "That is a good question, let me give that a try in the lab and see what results we get with different middlewares.",
"parentUuid": "60f1da49_a0495f7c",
"range": {
"startLine": 9,
"startChar": 106,
"endLine": 9,
"endChar": 132
},
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +64,24 @@
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b289cbef_63dc9f5a",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 29541
},
"writtenOn": "2023-11-02T11:44:13Z",
"side": 1,
"message": "Yes, that is also one thing i found when troubleshooting this, moving the ceilometermiddleware to the end of the pipeline gives it access to the necessary environment variables after all other middlewares are done. Have not tested without the swift.backend_path patch but that looks like a reasonable theory.\n\nI have not, this patch is based purely on my own testing. It would be interesting to hear how it would affect others though.\n\nThat is a fair question, talking from our own view we want to measure client requests (throughput and requests) for billing purposes (even though different middlewares can make multiple backend calls I think the actual client requests is cleanest to use). I suppose that there are other use cases where backend requests are more relevant though that would in my opinion probably work better to measure on the actual backends than in the incoming proxy pipeline.\n\nYour response made me think twice if there might be a more clean way of solving this. One thought is by putting the ceilometermiddleware in the internal-proxy pipeline though i have to admit that my understanding of that implementation is limited and am not really sure if that is what we want to measure.",
"parentUuid": "eeaaeb31_8b903fbf",
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {