openstack
/
ceilometermiddleware
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
CC: Gerrit User 32240 <32240@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34975 \u003c34975@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32240\u003e replied on the change"}
This commit is contained in:
Gerrit User 32240 2023-09-27 11:49:15 +00:00 committed by Gerrit Code Review
parent b9986b05c1
commit df3b9ee956
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
ad3ce1300d1240cdca2a56b569e222e1cab7c1bb
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "871bc69f_6b507ade",
"filename": ".zuul.yaml",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 32240
},
"writtenOn": "2023-09-27T11:49:15Z",
"side": 1,
"message": "It would be neat if we could add here as well.\n```\n# TODO: Update the plugins so they work with global venv\n```",
"revId": "ad3ce1300d1240cdca2a56b569e222e1cab7c1bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -16,6 +33,24 @@
"message": "Shouldn\u0027t we also have a bug or folow-up revert similarly to this change in aodh? https://review.opendev.org/c/openstack/aodh/+/892769",
"revId": "ad3ce1300d1240cdca2a56b569e222e1cab7c1bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "18dc296f_5a88ead5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 32240
},
"writtenOn": "2023-09-27T11:49:15Z",
"side": 1,
"message": "Yes, bugs linked in that change must be added here as well.",
"parentUuid": "1a29568c_9ccd6059",
"revId": "ad3ce1300d1240cdca2a56b569e222e1cab7c1bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}