Add unit tests for charm layer
This commit is contained in:
James Page
parent
a33a95676e
commit
e988874252
|
|
@ -6,6 +6,7 @@ import charmhelpers.core.hookenv as hookenv
|
|||
import charm.openstack.aodh as aodh
|
||||
|
||||
|
||||
# Minimal inferfaces required for operation
|
||||
MINIMAL_INTERFACES = [
|
||||
'shared-db.available',
|
||||
'identity-service.available',
|
||||
|
|
@ -58,8 +59,8 @@ def render_unclustered(*args):
|
|||
render(*args)
|
||||
|
||||
|
||||
@reactive.when('cluster.available')
|
||||
@reactive.when(*MINIMAL_INTERFACES)
|
||||
@reactive.when('cluster.available',
|
||||
*MINIMAL_INTERFACES)
|
||||
def render_clustered(*args):
|
||||
render(*args)
|
||||
|
||||
|
|
|
|||
|
|
@ -0,0 +1,6 @@
|
|||
flake8>=2.2.4,<=2.4.1
|
||||
os-testr>=0.4.1
|
||||
charms.reactive
|
||||
mock>=1.2
|
||||
coverage>=3.6
|
||||
git+https://github.com/openstack-charmers/charms.openstack#egg=charms.openstack
|
||||
|
|
@ -0,0 +1,28 @@
|
|||
import sys
|
||||
import mock
|
||||
|
||||
sys.path.append('src')
|
||||
sys.path.append('src/lib')
|
||||
|
||||
# Mock out charmhelpers so that we can test without it.
|
||||
# also stops sideeffects from occuring.
|
||||
charmhelpers = mock.MagicMock()
|
||||
sys.modules['charmhelpers'] = charmhelpers
|
||||
sys.modules['charmhelpers.core'] = charmhelpers.core
|
||||
sys.modules['charmhelpers.core.hookenv'] = charmhelpers.core.hookenv
|
||||
sys.modules['charmhelpers.core.host'] = charmhelpers.core.host
|
||||
sys.modules['charmhelpers.core.templating'] = charmhelpers.core.templating
|
||||
sys.modules['charmhelpers.contrib'] = charmhelpers.contrib
|
||||
sys.modules['charmhelpers.contrib.openstack'] = charmhelpers.contrib.openstack
|
||||
sys.modules['charmhelpers.contrib.openstack.utils'] = (
|
||||
charmhelpers.contrib.openstack.utils)
|
||||
sys.modules['charmhelpers.contrib.openstack.templating'] = (
|
||||
charmhelpers.contrib.openstack.templating)
|
||||
sys.modules['charmhelpers.contrib.network'] = charmhelpers.contrib.network
|
||||
sys.modules['charmhelpers.contrib.network.ip'] = (
|
||||
charmhelpers.contrib.network.ip)
|
||||
sys.modules['charmhelpers.fetch'] = charmhelpers.fetch
|
||||
sys.modules['charmhelpers.cli'] = charmhelpers.cli
|
||||
sys.modules['charmhelpers.contrib.hahelpers'] = charmhelpers.contrib.hahelpers
|
||||
sys.modules['charmhelpers.contrib.hahelpers.cluster'] = (
|
||||
charmhelpers.contrib.hahelpers.cluster)
|
||||
|
|
@ -0,0 +1,166 @@
|
|||
from __future__ import absolute_import
|
||||
from __future__ import print_function
|
||||
|
||||
import unittest
|
||||
|
||||
import mock
|
||||
|
||||
import reactive.aodh_handlers as handlers
|
||||
|
||||
|
||||
_when_args = {}
|
||||
_when_not_args = {}
|
||||
|
||||
|
||||
def mock_hook_factory(d):
|
||||
|
||||
def mock_hook(*args, **kwargs):
|
||||
|
||||
def inner(f):
|
||||
# remember what we were passed. Note that we can't actually
|
||||
# determine the class we're attached to, as the decorator only gets
|
||||
# the function.
|
||||
try:
|
||||
d[f.__name__].append(dict(args=args, kwargs=kwargs))
|
||||
except KeyError:
|
||||
d[f.__name__] = [dict(args=args, kwargs=kwargs)]
|
||||
return f
|
||||
return inner
|
||||
return mock_hook
|
||||
|
||||
|
||||
class TestAodhHandlers(unittest.TestCase):
|
||||
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
cls._patched_when = mock.patch('charms.reactive.when',
|
||||
mock_hook_factory(_when_args))
|
||||
cls._patched_when_started = cls._patched_when.start()
|
||||
cls._patched_when_not = mock.patch('charms.reactive.when_not',
|
||||
mock_hook_factory(_when_not_args))
|
||||
cls._patched_when_not_started = cls._patched_when_not.start()
|
||||
# force requires to rerun the mock_hook decorator:
|
||||
# try except is Python2/Python3 compatibility as Python3 has moved
|
||||
# reload to importlib.
|
||||
try:
|
||||
reload(handlers)
|
||||
except NameError:
|
||||
import importlib
|
||||
importlib.reload(handlers)
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(cls):
|
||||
cls._patched_when.stop()
|
||||
cls._patched_when_started = None
|
||||
cls._patched_when = None
|
||||
cls._patched_when_not.stop()
|
||||
cls._patched_when_not_started = None
|
||||
cls._patched_when_not = None
|
||||
# and fix any breakage we did to the module
|
||||
try:
|
||||
reload(handlers)
|
||||
except NameError:
|
||||
import importlib
|
||||
importlib.reload(handlers)
|
||||
|
||||
def setUp(self):
|
||||
self._patches = {}
|
||||
self._patches_start = {}
|
||||
|
||||
def tearDown(self):
|
||||
for k, v in self._patches.items():
|
||||
v.stop()
|
||||
setattr(self, k, None)
|
||||
self._patches = None
|
||||
self._patches_start = None
|
||||
|
||||
def patch(self, obj, attr, return_value=None):
|
||||
mocked = mock.patch.object(obj, attr)
|
||||
self._patches[attr] = mocked
|
||||
started = mocked.start()
|
||||
started.return_value = return_value
|
||||
self._patches_start[attr] = started
|
||||
setattr(self, attr, started)
|
||||
|
||||
def test_registered_hooks(self):
|
||||
# test that the hooks actually registered the relation expressions that
|
||||
# are meaningful for this interface: this is to handle regressions.
|
||||
# The keys are the function names that the hook attaches to.
|
||||
when_patterns = {
|
||||
'setup_amqp_req': ('amqp.connected', ),
|
||||
'setup_database': ('shared-db.connected', ),
|
||||
'setup_endpoint': ('identity-service.connected', ),
|
||||
'render_unclustered': ('shared-db.available',
|
||||
'identity-service.available',
|
||||
'amqp.available',),
|
||||
'render_clustered': ('shared-db.available',
|
||||
'identity-service.available',
|
||||
'amqp.available',
|
||||
'cluster.available',),
|
||||
'run_db_migration': ('config.complete', ),
|
||||
'cluster_connected': ('ha.connected', ),
|
||||
}
|
||||
when_not_patterns = {
|
||||
'install_packages': ('charm.installed', ),
|
||||
'render_unclustered': ('cluster.available', ),
|
||||
'run_db_migration': ('db.synced', ),
|
||||
}
|
||||
# check the when hooks are attached to the expected functions
|
||||
for t, p in [(_when_args, when_patterns),
|
||||
(_when_not_args, when_not_patterns)]:
|
||||
for f, args in t.items():
|
||||
# check that function is in patterns
|
||||
self.assertTrue(f in p.keys(),
|
||||
"{} not found".format(f))
|
||||
# check that the lists are equal
|
||||
print(args)
|
||||
# [{'kwargs': {}, 'args': ('amqp.connected',)}]
|
||||
l = []
|
||||
for a in args:
|
||||
l += a['args'][:]
|
||||
#l = [enumerate(a['args']) for a in args]
|
||||
self.assertEqual(sorted(l), sorted(p[f]),
|
||||
"{}: incorrect state registration".format(f))
|
||||
|
||||
def test_install_packages(self):
|
||||
self.patch(handlers.aodh, 'install')
|
||||
self.patch(handlers.reactive, 'set_state')
|
||||
handlers.install_packages()
|
||||
self.install.assert_called_once_with()
|
||||
self.set_state.assert_called_once_with('charm.installed')
|
||||
|
||||
def test_setup_amqp_req(self):
|
||||
self.patch(handlers.aodh, 'assess_status')
|
||||
amqp = mock.MagicMock()
|
||||
reply = {
|
||||
'rabbit-user': 'user1',
|
||||
'rabbit-vhost': 'vhost1',
|
||||
}
|
||||
handlers.setup_amqp_req(amqp)
|
||||
amqp.request_access.assert_called_once_with(
|
||||
username='aodh', vhost='openstack')
|
||||
|
||||
def test_database(self):
|
||||
database = mock.MagicMock()
|
||||
reply = {
|
||||
'database': 'db1',
|
||||
'database-user': 'dbuser1',
|
||||
}
|
||||
self.patch(handlers.hookenv, 'unit_private_ip', 'private_ip')
|
||||
self.patch(handlers.aodh, 'assess_status')
|
||||
handlers.setup_database(database)
|
||||
database.configure.assert_called_once_with(
|
||||
'aodh', 'aodh', 'private_ip')
|
||||
|
||||
def test_setup_endpoint(self):
|
||||
self.patch(handlers.aodh, 'setup_endpoint')
|
||||
self.patch(handlers.aodh, 'assess_status')
|
||||
handlers.setup_endpoint('endpoint_object')
|
||||
self.setup_endpoint.assert_called_once_with('endpoint_object')
|
||||
|
||||
def test_render_unclustered(self):
|
||||
self.patch(handlers.aodh, 'render_configs')
|
||||
self.patch(handlers.aodh, 'assess_status')
|
||||
handlers.render_unclustered('arg1', 'arg2')
|
||||
self.render_configs.assert_called_once_with(('arg1', 'arg2', ))
|
||||
self.assess_status.assert_called_once()
|
||||
|
|
@ -0,0 +1,113 @@
|
|||
from __future__ import absolute_import
|
||||
from __future__ import print_function
|
||||
|
||||
import unittest
|
||||
|
||||
import mock
|
||||
|
||||
import charm.openstack.aodh as aodh
|
||||
|
||||
|
||||
class Helper(unittest.TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self._patches = {}
|
||||
self._patches_start = {}
|
||||
|
||||
def tearDown(self):
|
||||
for k, v in self._patches.items():
|
||||
v.stop()
|
||||
setattr(self, k, None)
|
||||
self._patches = None
|
||||
self._patches_start = None
|
||||
|
||||
def patch(self, obj, attr, return_value=None, **kwargs):
|
||||
mocked = mock.patch.object(obj, attr, **kwargs)
|
||||
self._patches[attr] = mocked
|
||||
started = mocked.start()
|
||||
started.return_value = return_value
|
||||
self._patches_start[attr] = started
|
||||
setattr(self, attr, started)
|
||||
|
||||
|
||||
class TestOpenStackAodh(Helper):
|
||||
|
||||
def test_install(self):
|
||||
self.patch(aodh.AodhCharm.singleton, 'install')
|
||||
aodh.install()
|
||||
self.install.assert_called_once_with()
|
||||
|
||||
def test_setup_endpoint(self):
|
||||
self.patch(aodh.AodhCharm, 'service_name',
|
||||
new_callable=mock.PropertyMock)
|
||||
self.patch(aodh.AodhCharm, 'region',
|
||||
new_callable=mock.PropertyMock)
|
||||
self.patch(aodh.AodhCharm, 'public_url',
|
||||
new_callable=mock.PropertyMock)
|
||||
self.patch(aodh.AodhCharm, 'internal_url',
|
||||
new_callable=mock.PropertyMock)
|
||||
self.patch(aodh.AodhCharm, 'admin_url',
|
||||
new_callable=mock.PropertyMock)
|
||||
self.service_name.return_value = 'type1'
|
||||
self.region.return_value = 'region1'
|
||||
self.public_url.return_value = 'public_url'
|
||||
self.internal_url.return_value = 'internal_url'
|
||||
self.admin_url.return_value = 'admin_url'
|
||||
keystone = mock.MagicMock()
|
||||
aodh.setup_endpoint(keystone)
|
||||
keystone.register_endpoints.assert_called_once_with(
|
||||
'type1', 'region1', 'public_url', 'internal_url', 'admin_url')
|
||||
|
||||
def test_render_configs(self):
|
||||
self.patch(aodh.AodhCharm.singleton, 'render_with_interfaces')
|
||||
aodh.render_configs('interfaces-list')
|
||||
self.render_with_interfaces.assert_called_once_with(
|
||||
'interfaces-list')
|
||||
|
||||
|
||||
class TestAodhAdapters(Helper):
|
||||
|
||||
@mock.patch('charmhelpers.core.hookenv.config')
|
||||
def test_aodh_adapters(self, config):
|
||||
reply = {
|
||||
'keystone-api-version': '2',
|
||||
}
|
||||
config.side_effect = lambda: reply
|
||||
amqp_relation = mock.MagicMock()
|
||||
amqp_relation.relation_name = 'amqp'
|
||||
shared_db_relation = mock.MagicMock()
|
||||
shared_db_relation.relation_name = 'shared_db'
|
||||
other_relation = mock.MagicMock()
|
||||
other_relation.relation_name = 'other'
|
||||
other_relation.thingy = 'help'
|
||||
# verify that the class is created with a AodhConfigurationAdapter
|
||||
b = aodh.AodhAdapters([amqp_relation,
|
||||
shared_db_relation,
|
||||
other_relation])
|
||||
# ensure that the relevant things got put on.
|
||||
self.assertTrue(
|
||||
isinstance(
|
||||
b.other,
|
||||
aodh.charms_openstack.adapters.OpenStackRelationAdapter))
|
||||
self.assertTrue(
|
||||
isinstance(
|
||||
b.options,
|
||||
aodh.charms_openstack.adapters.APIConfigurationAdapter))
|
||||
|
||||
|
||||
class TestAodhCharm(Helper):
|
||||
|
||||
def test__init__(self):
|
||||
self.patch(aodh.ch_utils, 'os_release')
|
||||
aodh.AodhCharm()
|
||||
self.os_release.assert_called_once_with('python-keystonemiddleware')
|
||||
|
||||
def test_install(self):
|
||||
b = aodh.AodhCharm()
|
||||
self.patch(aodh.charms_openstack.charm.OpenStackCharm,
|
||||
'configure_source')
|
||||
self.patch(aodh.charms_openstack.charm.OpenStackCharm,
|
||||
'install')
|
||||
b.install()
|
||||
self.configure_source.assert_called_once_with()
|
||||
self.install.assert_called_once_with()
|
||||
Loading…
Reference in New Issue