openstack
/
charm-ceph-osd
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 15382 <15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 17df4c4061ee8f83bb7176bd296c4bdfde50b358
Attention: {"person_ident":"Gerrit User 36857 \u003c36857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
Gerrit User 15382 2024-04-03 17:14:38 +00:00 committed by Gerrit Code Review
parent 2b263e69d8
commit a87efadefb
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
5d0ddb915fdf4eff2e6f2d770de5a42486e252fb
View File

@ -50,6 +50,23 @@
"message": "charm-recheck # addtl CI updates",
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4ffd52a5_c6ba2a90",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 15382
},
"writtenOn": "2024-04-03T17:14:38Z",
"side": 1,
"message": "Hey Federico, many thanks for picking this up -- and apologies for the latency on this.\n\nThis looks good to me in general, I wonder though if you\u0027d be able to add some testing around this? \n\nI think a unit test in unit_tests.test_ceph_hooks.CephHooksTestCase would suffice.",
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}