108 lines
3.8 KiB
Plaintext
108 lines
3.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ae75c728_eb354d81",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-03-12T08:48:24Z",
|
|
"side": 1,
|
|
"message": "Hey @Peter. I requested a review from you because you looked a bit active in other change reviews. :)",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3ab3a684_3a7093db",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15382
|
|
},
|
|
"writtenOn": "2024-03-22T17:20:17Z",
|
|
"side": 1,
|
|
"message": "charm-recheck # retry for fixed Zaza integration",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9c6793f9_e16b33cb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15382
|
|
},
|
|
"writtenOn": "2024-04-03T14:11:52Z",
|
|
"side": 1,
|
|
"message": "charm-recheck # addtl CI updates",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4ffd52a5_c6ba2a90",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15382
|
|
},
|
|
"writtenOn": "2024-04-03T17:14:38Z",
|
|
"side": 1,
|
|
"message": "Hey Federico, many thanks for picking this up -- and apologies for the latency on this.\n\nThis looks good to me in general, I wonder though if you\u0027d be able to add some testing around this? \n\nI think a unit test in unit_tests.test_ceph_hooks.CephHooksTestCase would suffice.",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1e894435_b2dfe038",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-04T13:35:29Z",
|
|
"side": 1,
|
|
"message": "Hey :)\nThanks for looking at this. I agree and will add a unit test.\nThere\u0027s another issue which you might help me with: the charm_helpers function we use to get ipv6 addresses (hooks/charmhelpers/contrib/network/ip.py@get_ipv6_addr) from any interface is broken. It\u0027s broken in any juju charm that uses charmhelpers.\nYou can read about the issue here: https://github.com/juju/charm-helpers/issues/877\nI made a PR for it too; since it\u0027s taking so long and no one has replied yet, maybe you can reach out and speed it up? \nI would very much rather have that fix in the next release of charm_ceph_osd too, otherwise an ipv6 only environment like mine would not work with static ipv6 addresses. I was forced to patch that file too in order to make the charm work ):",
|
|
"parentUuid": "4ffd52a5_c6ba2a90",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ac47f17a_13adcc5b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-09T12:04:44Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "1e894435_b2dfe038",
|
|
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |