21 lines
1.2 KiB
Plaintext
21 lines
1.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "846861d4_7fbfbd7c",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-04T13:58:29Z",
|
|
"side": 1,
|
|
"message": "I patched get_ipv6_addr to return a sample address. \nI\u0027d like to bring to your attention another issue. \nThe get_ceph_context function (and other ones) call get_ipv6_addr with no arguments. The default behavior is for it to return only dynamic addresses, and I can see that whover called it intended this by naming the variables like `dynamic_ipv6_address \u003d get_ipv6_addr()[0]`.\nDoes it really make sense? A static ipv6 address is just as good. We don\u0027t get only static ones in ipv4, why wouldn\u0027t we want staic 6\u0027s?\nI though it could be a good idea, to fix the get_ipv6_addr calls in this change request: fixing both the bind flag and the allowed address type.\nIf you think it belongs to a different issue, I can open another one, make another patch and submit it after testing it.",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |