93 lines
3.9 KiB
Plaintext
93 lines
3.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "846861d4_7fbfbd7c",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-04T13:58:29Z",
|
|
"side": 1,
|
|
"message": "I patched get_ipv6_addr to return a sample address. \nI\u0027d like to bring to your attention another issue. \nThe get_ceph_context function (and other ones) call get_ipv6_addr with no arguments. The default behavior is for it to return only dynamic addresses, and I can see that whover called it intended this by naming the variables like `dynamic_ipv6_address \u003d get_ipv6_addr()[0]`.\nDoes it really make sense? A static ipv6 address is just as good. We don\u0027t get only static ones in ipv4, why wouldn\u0027t we want staic 6\u0027s?\nI though it could be a good idea, to fix the get_ipv6_addr calls in this change request: fixing both the bind flag and the allowed address type.\nIf you think it belongs to a different issue, I can open another one, make another patch and submit it after testing it.",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "069806b9_f5436137",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 15382
|
|
},
|
|
"writtenOn": "2024-04-09T10:47:34Z",
|
|
"side": 1,
|
|
"message": "Hi @federico, \nafaict at the time this was implemented there might have incompat. with ceph mon that prevented non-dynamic addresses from working -- this might have changed though. Feel free to investigate -- I\u0027d recommend to put this into a separate MR however.",
|
|
"parentUuid": "846861d4_7fbfbd7c",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1f0700ad_38f9f8b7",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-09T12:04:44Z",
|
|
"side": 1,
|
|
"message": "Sounds good. I\u0027ll resolve the other comment threads.\nThe Zuul build fails because we are putting mock objects inside other mock objects in the tests, so I\u0027d ignore the py311 build.",
|
|
"parentUuid": "069806b9_f5436137",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "dacb48de_171a2c6f",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 36857
|
|
},
|
|
"writtenOn": "2024-04-09T12:15:40Z",
|
|
"side": 1,
|
|
"message": "Just saw that your change request (915316) fixes that issue.\nWhat should I do in this case?\nDo I merge master into this branch and push a new patchset once yours is merged?\nSorry but this is my first time doing open source \u0027:)",
|
|
"parentUuid": "1f0700ad_38f9f8b7",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9dad45de_955cd88c",
|
|
"filename": "unit_tests/test_ceph_hooks.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 438,
|
|
"author": {
|
|
"id": 15382
|
|
},
|
|
"writtenOn": "2024-04-09T14:25:38Z",
|
|
"side": 1,
|
|
"message": "Hey @Federico, no worries at all!\n\nMy change should merge shortly -- I\u0027d suggest to pull and rebase onto that",
|
|
"parentUuid": "dacb48de_171a2c6f",
|
|
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |