Update patch set 18
Patch Set 18: (3 comments) Patch-set: 18 Attention: {"person_ident":"Gerrit User 34952 \u003c34952@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34952\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 13178 \u003c13178@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34952\u003e replied on the change"}
This commit is contained in:
parent
0e30f2d09b
commit
410e468fed
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "13dae860_90824641",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 34952
|
||||
},
|
||||
"writtenOn": "2024-04-30T06:40:41Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for the quick patch Ionut, I have left one comment on the config defaults, my plan is to re-review your PRs today.",
|
||||
"revId": "869ed352909766e6a38db97139fe82c2123e1536",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -232,6 +232,30 @@
|
|||
"revId": "f154f09c82bf936f8d0711e4747371642cb2e3c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "bb2e836a_a369790d",
|
||||
"filename": "config.yaml",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 434,
|
||||
"author": {
|
||||
"id": 34952
|
||||
},
|
||||
"writtenOn": "2024-04-30T06:40:41Z",
|
||||
"side": 1,
|
||||
"message": "Got it, I now see that having this value empty will also result in the same behaviour, but, having a sensible default (like \"enabled\") suggests \"sync is allowed and enabled by default\" more clearly, just like how having \"symmetrical\" default suggests \"sync happens in both direction by default\" more clearly.",
|
||||
"parentUuid": "2b89a900_2991bf3b",
|
||||
"range": {
|
||||
"startLine": 434,
|
||||
"startChar": 4,
|
||||
"endLine": 434,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "f154f09c82bf936f8d0711e4747371642cb2e3c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -279,6 +303,30 @@
|
|||
"revId": "f154f09c82bf936f8d0711e4747371642cb2e3c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "bed83f65_bc2e9f86",
|
||||
"filename": "hooks/hooks.py",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 864,
|
||||
"author": {
|
||||
"id": 34952
|
||||
},
|
||||
"writtenOn": "2024-04-30T06:40:41Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "e6c2e008_7566d8c9",
|
||||
"range": {
|
||||
"startLine": 860,
|
||||
"startChar": 0,
|
||||
"endLine": 864,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "f154f09c82bf936f8d0711e4747371642cb2e3c7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
Loading…
Reference in New Issue