openstack
/
charm-cinder
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 5112 \u003c5112@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_5112\u003e replied on the change"}
This commit is contained in:
Gerrit User 5112 2024-04-12 00:15:32 +00:00 committed by Gerrit Code Review
parent 8553979e96
commit d0dac68988
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
1bbdd36d489c172dfc66339ffd05260044a32c13
View File

@ -33,6 +33,23 @@
"message": "Hi @seyeong, the backport for \u003c xena it\u0027s not clean and it\u0027s causing the following error:\n\nNameError: name \u0027_resolve\u0027 is not defined\n\nWe need to evaluate, how much cold would be needed to solve (not a lot I suppose).\nAlso, we will need to test and make sure that each release is clean and has no regressions.",
"revId": "1bbdd36d489c172dfc66339ffd05260044a32c13",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "744819dc_160efcb4",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 5112
},
"writtenOn": "2024-04-12T00:15:32Z",
"side": 1,
"message": "listing related commit ( not done yet )\n\n1299b2da5611ba331ecc47c01e387937565aaad4 charm-helpers sync\n9221ef56746cab5948e94ae8e9822b7d027ea842 Updates for zed stable branch creation\n\n##\nor just use rdata.get instead of _resolve. in that case as 1299b2da5611ba331ecc47c01e387937565aaad4 commit says, \u0027get service token\u0027 may not work properly. I\u0027m going to check this out today",
"revId": "1bbdd36d489c172dfc66339ffd05260044a32c13",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}