charm-cinder/80115a2cb219c72b36adfb60b94c3cd56dbaf086

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "66d4a0c2_aec0577b",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 10058
      },
      "writtenOn": "2024-02-28T12:27:10Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "542107d3_e92b9c33",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-05T14:42:16Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7809e645_3bf08fa1",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-06T14:56:58Z",
      "side": 1,
      "message": "2024-03-05 17:04:16 INFO unit.cinder/0.juju-log server.go:316 identity relation\u0027s interface, identity-service, is related awaiting the following data from the relationship: service_user_id.",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "39bb833a_aecf1a49",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-06T14:57:26Z",
      "side": 1,
      "message": "I suppose https://review.opendev.org/c/openstack/charm-keystone/+/900298 has to merge first",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "271bd41f_d71d25ff",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-11T17:15:09Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b2e9cacf_d6d67a85",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-12T10:42:17Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7d609c63_a471aae7",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-12T10:42:33Z",
      "side": 1,
      "message": "I probably had rechecked before the keystone charm had been rebuilt \u003cfacepalm\u003e",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "311f0f80_835333a6",
        "filename": "charmhelpers/contrib/openstack/context.py",
        "patchSetId": 3
      },
      "lineNbr": 528,
      "author": {
        "id": 2424
      },
      "writtenOn": "2024-02-28T15:24:58Z",
      "side": 1,
      "message": "this change needs to land on charm-helpers first.\n\nThe PR https://github.com/juju/charm-helpers/pull/874 needs to be backported to stable/bobcat, and then do a sync-up into this charm to get those changes.",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7ee7e779_4a956c2e",
        "filename": "charmhelpers/contrib/openstack/context.py",
        "patchSetId": 3
      },
      "lineNbr": 528,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-05T14:43:08Z",
      "side": 1,
      "message": "@Felipe the charmhelpers change is included in the code, why does it need a sync?",
      "parentUuid": "311f0f80_835333a6",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e7f26525_6783cea2",
        "filename": "charmhelpers/contrib/openstack/context.py",
        "patchSetId": 3
      },
      "lineNbr": 528,
      "author": {
        "id": 2424
      },
      "writtenOn": "2024-03-05T20:56:21Z",
      "side": 1,
      "message": "https://github.com/juju/charm-helpers/blob/stable/bobcat/charmhelpers/contrib/openstack/context.py#L526-L529\n\nBecause if anyone after you get this merged comes in does a \"c-h sync\" will wipe/rollback your changes. The charmhelpers directory is a vendoring , not a fork.",
      "parentUuid": "7ee7e779_4a956c2e",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4700d770_7de9e698",
        "filename": "charmhelpers/contrib/openstack/context.py",
        "patchSetId": 3
      },
      "lineNbr": 528,
      "author": {
        "id": 14567
      },
      "writtenOn": "2024-03-06T12:35:45Z",
      "side": 1,
      "message": "oh yes, for sure, but that\u0027s not what I meant. I know that the charmhelpers change should be merged first to avoid someone else overriding the change in charm-cinder\u0027s with a new sync, but what I meant to say is that the change isn\u0027t supposed to be necessary for the CI to pass, because the code being tested in the CI is the one that effectively is the same as if the charmhelpers patch had merged and synced, as it is already included in this patch itself.",
      "parentUuid": "e7f26525_6783cea2",
      "revId": "80115a2cb219c72b36adfb60b94c3cd56dbaf086",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}