openstack
/
charm-cloudkitty
Code Issues Proposed changes

Update patch set 15 

Patch Set 15: Code-Review-1

(4 comments)

Patch-set: 15
Reviewer: Gerrit User 8992 <8992@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 8992 2022-10-06 19:28:26 +00:00 committed by Gerrit Code Review
parent a8470dd39f
commit 18240ec813
2 changed files with 75 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
43940982fa0d96a520cdea84ea65139eb15bb51f
View File

@ -51,6 +51,24 @@
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4bf1134c_6c23e311",
"filename": "README.md",
"patchSetId": 13
},
"lineNbr": 171,
"author": {
"id": 8992
},
"writtenOn": "2022-10-06T19:28:26Z",
"side": 1,
"message": "Done",
"parentUuid": "bd900c1c_5e689361",
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +86,24 @@
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "213a96a8_25bdfc2c",
"filename": "charmcraft.yaml",
"patchSetId": 13
},
"lineNbr": 27,
"author": {
"id": 8992
},
"writtenOn": "2022-10-06T19:28:26Z",
"side": 1,
"message": "Done",
"parentUuid": "867fb388_d1274168",
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -84,6 +120,24 @@
"message": "I\u0027m not sure why this file is included... its not included in any of the repositories for charms and I think this maybe shouldn\u0027t be included?",
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "72c2bdfb_ae7b5dca",
"filename": "pyvenv.cfg",
"patchSetId": 13
},
"lineNbr": 0,
"author": {
"id": 8992
},
"writtenOn": "2022-10-06T19:28:26Z",
"side": 1,
"message": "Done",
"parentUuid": "bfb31f14_436dfb00",
"revId": "43940982fa0d96a520cdea84ea65139eb15bb51f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
d7b26af44d2877676eaa66cf2be114ec9a52915f Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "05cd0ee7_7aaa6401",
"filename": "charmcraft.yaml",
"patchSetId": 15
},
"lineNbr": 31,
"author": {
"id": 8992
},
"writtenOn": "2022-10-06T19:28:26Z",
"side": 1,
"message": "the \u0027architectures\u0027 is duplicated here",
"revId": "d7b26af44d2877676eaa66cf2be114ec9a52915f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}