openstack
/
charm-designate-bind
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 19298 <19298@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 449fc45bf5f25bae217df61ea045a0d11e5497f5
Attention: {"person_ident":"Gerrit User 36101 \u003c36101@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_19298\u003e replied on the change"}
This commit is contained in:
Gerrit User 19298 2023-10-02 20:50:36 +00:00 committed by Gerrit Code Review
parent e0d74cf3fa
commit 0564b92234
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
1f8fa19f1ed3d492cd496a83d59fbff30335598b Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "9a08ee84_afc883b6",
"filename": "src/README.md",
"patchSetId": 1
},
"lineNbr": 69,
"author": {
"id": 19298
},
"writtenOn": "2023-10-02T20:50:36Z",
"side": 1,
"message": "Please remove trailing whitespaces.",
"revId": "1f8fa19f1ed3d492cd496a83d59fbff30335598b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ddd8675a_1ee02375",
"filename": "src/README.md",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 19298
},
"writtenOn": "2023-10-02T20:50:36Z",
"side": 1,
"message": "Maybe better:\n\nIf this option is not set, zone transfers are not allowed. Note that this is different from the default BIND9 behavior which allows zone transfers from anywhere.",
"range": {
"startLine": 77,
"startChar": 0,
"endLine": 77,
"endChar": 128
},
"revId": "1f8fa19f1ed3d492cd496a83d59fbff30335598b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "30b706a4_e2989dee",
"filename": "src/README.md",
"patchSetId": 1
},
"lineNbr": 79,
"author": {
"id": 19298
},
"writtenOn": "2023-10-02T20:50:36Z",
"side": 1,
"message": "Maybe better:\n\nTo restore BIND9\u0027s default behavior, set this option to `any`:",
"revId": "1f8fa19f1ed3d492cd496a83d59fbff30335598b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}