openstack
/
charm-glance-simplestreams-sync
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(5 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 5559 2022-09-23 08:47:26 +00:00 committed by Gerrit Code Review
parent 7ed61354d6
commit b0084e032f
2 changed files with 114 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
76a458391e215127e0cb827534df3cf3c88ee0ea
View File

@ -23,6 +23,30 @@
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "580b65a1_638a2c59",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 5559
},
"writtenOn": "2022-09-23T08:47:26Z",
"side": 1,
"message": "this patch requires changed made on `simplestreams`, which its snap has not yet been rolled out to stable channel.",
"parentUuid": "49719f2d_e5ae345f",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 63
},
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e129cb0f_cac8ff9e",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 23,
"author": {
"id": 5559
},
"writtenOn": "2022-09-23T08:47:26Z",
"side": 1,
"message": "Ack",
"parentUuid": "ff077b26_8a84a94a",
"range": {
"startLine": 23,
"startChar": 0,
"endLine": 23,
"endChar": 23
},
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "16e2b14d_f611abc4",
"filename": "files/glance_simplestreams_sync.py",
"patchSetId": 4
},
"lineNbr": 295,
"author": {
"id": 5559
},
"writtenOn": "2022-09-23T08:47:26Z",
"side": 1,
"message": "not sure what you want me to change here. all if\u0027s have a blank line above.",
"parentUuid": "f8ef7d4d_7fda3ea4",
"range": {
"startLine": 295,
"startChar": 11,
"endLine": 295,
"endChar": 15
},
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -91,6 +163,30 @@
},
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a4e1349b_ac028152",
"filename": "tests/bundles/jammy-yoga.yaml",
"patchSetId": 4
},
"lineNbr": 81,
"author": {
"id": 5559
},
"writtenOn": "2022-09-23T08:47:26Z",
"side": 1,
"message": "same as #21.\n\n\u003e this patch requires changed made on `simplestreams`, which its snap has not yet been rolled out to stable channel.",
"parentUuid": "b908fe13_a34f644e",
"range": {
"startLine": 81,
"startChar": 5,
"endLine": 81,
"endChar": 24
},
"revId": "76a458391e215127e0cb827534df3cf3c88ee0ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
cd887d3f727e310931e9f16b21c6238af3ff3de6
View File

@ -33,6 +33,24 @@
"message": "This seems to be failing because simplestreams doesn\u0027t recognize the new \u0027--set-latest-property\u0027 argument",
"revId": "cd887d3f727e310931e9f16b21c6238af3ff3de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "99d538df_d5495f9a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 5559
},
"writtenOn": "2022-09-23T08:47:26Z",
"side": 1,
"message": "yes. `set-latest-property` is available on edge charm channel.\nalthough I tried to set `snap-channel\u003dedge` it didn\u0027t pull the latest version of simplestreams.\n\nI need some bandwidth to investigate that.",
"parentUuid": "012d6977_0f54d9bd",
"revId": "cd887d3f727e310931e9f16b21c6238af3ff3de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}