From d597eaedbb672c68b3c730ba4c039db9e4cdeaec Mon Sep 17 00:00:00 2001 From: Ryan Beisner Date: Fri, 8 Feb 2019 15:49:58 -0600 Subject: [PATCH] Update pre-install hooks to fail on error The pre-install operations may fail, yet that failure is not elevated to the user. This masks the failure and makes early package install issues difficult to troubleshoot. If the basic pre-install script fails, the charm should not proceed to later hooks as the requirements may not be met. Hashbangs for bash should specify -e (errexit) on all of the pre-install bash scripts. Change-Id: I61301f3ed953f685bca3c4060907ccda8cec6f49 Closes-bug: #1815243 Partial-bug: #1815231 --- hooks/install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hooks/install b/hooks/install index 83a9d3c..8e4c0c5 100755 --- a/hooks/install +++ b/hooks/install @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e # Wrapper to deal with newer Ubuntu versions that don't have py2 installed # by default.