openstack
/
charm-layer-openstack
Code Issues Proposed changes

Ensure endpoints are populated within actions 

When actions are run the reactive run_at{start,exit} methods are not
implicit run. This means that some data associated with endpoints
is missing. For example reactive.Endpoint.all_joined_units is always
None.

Change-Id: I565fb534612a06d76e6688ed4f06ad64bc42e512
This commit is contained in:
Liam Young 2021-05-11 08:00:13 +00:00
parent ba152d41b4
commit 207bac8bec
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
actions/os_actions.py
View File

@ -23,6 +23,7 @@ from charms.layer import basic
basic.bootstrap_charm_deps()
import charmhelpers.core.hookenv as hookenv
import charmhelpers.core as ch_core
import charms_openstack.bus
import charms_openstack.charm
@ -63,6 +64,9 @@ ACTIONS = {
def main(args):
# Manually trigger any register atstart events to ensure all endpoints
# are correctly setup, Bug #1916008.
ch_core.hookenv._run_atstart()
action_name = os.path.basename(args[0])
try:
action = ACTIONS[action_name]
@ -73,6 +77,7 @@ def main(args):
action(args)
except Exception as e:
hookenv.action_fail(str(e))
ch_core.hookenv._run_atexit()
if __name__ == "__main__":