diff --git a/9b92b8ef60e896465183f45b09609c81b6c80478 b/9b92b8ef60e896465183f45b09609c81b6c80478 index 6f6e4076..0f24af2a 100644 --- a/9b92b8ef60e896465183f45b09609c81b6c80478 +++ b/9b92b8ef60e896465183f45b09609c81b6c80478 @@ -135,6 +135,69 @@ "message": "charm-recheck", "revId": "9b92b8ef60e896465183f45b09609c81b6c80478", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "3f7e604f_bb9da7cd", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 20870 + }, + "writtenOn": "2024-04-19T10:04:13Z", + "side": 1, + "message": "The templates don\u0027t do an either-or on the cpu_models and cpu_model. I know it is done in the context, but it seems more \u0027obvious\u0027 if the template also shows that they are alternatives and shouldn\u0027t be used at the same time.", + "revId": "9b92b8ef60e896465183f45b09609c81b6c80478", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1b25dcdf_2c996192", + "filename": "templates/train/nova.conf", + "patchSetId": 2 + }, + "lineNbr": 292, + "author": { + "id": 20870 + }, + "writtenOn": "2024-04-19T10:04:13Z", + "side": 1, + "message": "This doesn\u0027t do what the config option says it does; i.e. cpu_model isn\u0027t set if cpu_models is set. This should probably be something like:\n\n {% if cpu_models -%}\n cpu_models \u003d {{ cpu_models }}\n {% elif cpu_model -%}\n cpu_model \u003d {{ cpu_model }}\n {% endif -%}\n \nand remove the `{% if cpu_mode. -%} .. {% endif -%}` below.", + "range": { + "startLine": 290, + "startChar": 0, + "endLine": 292, + "endChar": 12 + }, + "revId": "9b92b8ef60e896465183f45b09609c81b6c80478", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1c74e25d_9b2ce271", + "filename": "templates/yoga/nova.conf", + "patchSetId": 2 + }, + "lineNbr": 275, + "author": { + "id": 20870 + }, + "writtenOn": "2024-04-19T10:04:13Z", + "side": 1, + "message": "As per the other `nova.conf`.", + "range": { + "startLine": 273, + "startChar": 1, + "endLine": 275, + "endChar": 1 + }, + "revId": "9b92b8ef60e896465183f45b09609c81b6c80478", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file