From e9ecd8284fc1d1fc5c64496de7893d179f8315b5 Mon Sep 17 00:00:00 2001 From: James Page Date: Wed, 23 Jan 2019 17:09:15 +0000 Subject: [PATCH] upgrade-charm: filter previously installed packages The upgrade-charm hook installs any new packages required for the new charm version however this needs to be filtered against previously installed packages to ensure that pending package updates don't get applied to the system as a side effect of upgrading the charm. Change-Id: I6c490f9af2312dc42f2b56e0b7ce8c802e3aac1d Closes-Bug: 1812982 --- hooks/nova_compute_hooks.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hooks/nova_compute_hooks.py b/hooks/nova_compute_hooks.py index ccdc9818..8a30896e 100755 --- a/hooks/nova_compute_hooks.py +++ b/hooks/nova_compute_hooks.py @@ -419,7 +419,8 @@ def relation_broken(): @hooks.hook('upgrade-charm') @harden() def upgrade_charm(): - apt_install(determine_packages(), fatal=True) + apt_install(filter_installed_packages(determine_packages()), + fatal=True) # NOTE: ensure psutil install for hugepages configuration status_set('maintenance', 'Installing apt packages') apt_install(filter_installed_packages(['python-psutil']))