charm-nova-compute/9b92b8ef60e896465183f45b09609c81b6c80478

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "4f0e627e_26eb81a5",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 30534
      },
      "writtenOn": "2024-04-15T15:45:00Z",
      "side": 1,
      "message": "recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "a5f82d43_f37984dc",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 30534
      },
      "writtenOn": "2024-04-16T05:07:45Z",
      "side": 1,
      "message": "recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "6e3e84a0_184c4b56",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 1131
      },
      "writtenOn": "2024-04-16T19:50:28Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "150ac07c_a9feea64",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 30534
      },
      "writtenOn": "2024-04-17T07:09:13Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "26a5cc76_286c3d34",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 30534
      },
      "writtenOn": "2024-04-17T16:09:10Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "9aff4396_1426d87a",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 1131
      },
      "writtenOn": "2024-04-18T14:48:59Z",
      "side": 1,
      "message": "My canary patch passed Canonical CI fwiw, but perhaps was a fluke based on what this change is seeing\n\nhttps://review.opendev.org/c/openstack/charm-nova-compute/+/916111",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "51cc7b5f_579297fa",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 1131
      },
      "writtenOn": "2024-04-18T19:10:22Z",
      "side": 1,
      "message": "And my canary patch failed on a second run, so there is something flaky about the gate here.",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "040f237a_72d38a07",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 30534
      },
      "writtenOn": "2024-04-19T06:13:22Z",
      "side": 1,
      "message": "charm-recheck",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "3f7e604f_bb9da7cd",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 20870
      },
      "writtenOn": "2024-04-19T10:04:13Z",
      "side": 1,
      "message": "The templates don\u0027t do an either-or on the cpu_models and cpu_model.  I know it is done in the context, but it seems more \u0027obvious\u0027 if the template also shows that they are alternatives and shouldn\u0027t be used at the same time.",
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1b25dcdf_2c996192",
        "filename": "templates/train/nova.conf",
        "patchSetId": 2
      },
      "lineNbr": 292,
      "author": {
        "id": 20870
      },
      "writtenOn": "2024-04-19T10:04:13Z",
      "side": 1,
      "message": "This doesn\u0027t do what the config option says it does; i.e. cpu_model isn\u0027t set if cpu_models is set.  This should probably be something like:\n\n    {% if cpu_models -%}\n    cpu_models \u003d {{ cpu_models }}\n    {% elif cpu_model -%}\n    cpu_model \u003d {{ cpu_model }}\n    {% endif -%}\n   \nand remove the `{% if cpu_mode. -%} .. {% endif -%}` below.",
      "range": {
        "startLine": 290,
        "startChar": 0,
        "endLine": 292,
        "endChar": 12
      },
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1c74e25d_9b2ce271",
        "filename": "templates/yoga/nova.conf",
        "patchSetId": 2
      },
      "lineNbr": 275,
      "author": {
        "id": 20870
      },
      "writtenOn": "2024-04-19T10:04:13Z",
      "side": 1,
      "message": "As per the other `nova.conf`.",
      "range": {
        "startLine": 273,
        "startChar": 1,
        "endLine": 275,
        "endChar": 1
      },
      "revId": "9b92b8ef60e896465183f45b09609c81b6c80478",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}