openstack
/
charm-placement
Code Issues Proposed changes

Avoid multiple calls to create_ip_cert_links 

(This is a rebuild of the charm to pull in the fix that is in stable
charms.openstack.)

Prior to this change, the call to create_ip_cert_links was inside the
for loop of tls objects. This caused LP Bug#1866741 where a sym link
with the same certificate name would get overwritten with a new cert.
This meant the last certificate of [internal, admin, public] would be
written to all three.

This change calls create_ip_cert_links and state sets only once. It also
adds a warning log entry if we accidentally overwrite sym linked files in
the future.

Change-Id: Idd99fac8b5c48755b2ef2797deaa688cd2544281
Partial-Bug: #1866741
This commit is contained in:
Alex Kavanagh 2020-03-16 17:02:50 +00:00
parent 63acdcec74
commit 72a060167f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rebuild
View File

@ -2,4 +2,4 @@
# when dependencies of the charm change,
# but nothing in the charm needs to.
# simply change the uuid to something new
52737480-4839-11ea-8ea6-4bb6c0f4660c
eb195ac8-67a7-11ea-9396-039b43763b84

2
test-requirements.txt
View File

@ -11,4 +11,4 @@ charms.reactive
mock>=1.2
nose>=1.3.7
coverage>=3.6
git+https://github.com/openstack/charms.openstack.git#egg=charms.openstack
git+https://github.com/openstack/charms.openstack.git@stable/20.02#egg=charms.openstack