Update patch set 3
Patch Set 3: (7 comments) Patch-set: 3 Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
parent
4b7d8f3e02
commit
2bc5b2c9ef
|
@ -0,0 +1,141 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5fa63fdf_f6dd0df5",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "Hey Ionut, thanks for this, an interesting proposal.\n\nSome nits / questions below.",
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3b5635ad_81bd8ea3",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "Nit: s/Coud Sync/Cloud Sync/",
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "88acde15_0801267b",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "IIUC a profile contains data about buckets, targets and target paths, is that right?\n\nCan I ask that you more in detail which properties the tier config can take and how the proposed config syntax looks like?",
|
||||
"range": {
|
||||
"startLine": 79,
|
||||
"startChar": 0,
|
||||
"endLine": 88,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2c296240_b6a080fe",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 94,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "I could be misinterpreting this, but I\u0027d lean towards having a `default` profile instead. This would set profile props to a default value for all buckets that don\u0027t have a profile configured. Would this be possible?",
|
||||
"range": {
|
||||
"startLine": 90,
|
||||
"startChar": 0,
|
||||
"endLine": 94,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "377dc339_aaa69e64",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 106,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "It would be great to have an example here how a deployment with multiple targets would look",
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0fb912a4_b7e982d3",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 110,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "I believe there were discussions around an approach where the addtl cloud sync instances would be colocated on existing units, obviating the need for a separate cloud sync relation. Would it be possible to summarize the outcome of that discussion in the `Alternatives` section?",
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3d795fb9_e06be25a",
|
||||
"filename": "specs/2024.1/backlog/ceph-radosgw-cloud-sync.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 159,
|
||||
"author": {
|
||||
"id": 15382
|
||||
},
|
||||
"writtenOn": "2024-04-03T10:53:04Z",
|
||||
"side": 1,
|
||||
"message": "Mapping application names to profile names feels a bit magical, do you think this could be made more explicit?",
|
||||
"range": {
|
||||
"startLine": 157,
|
||||
"startChar": 1,
|
||||
"endLine": 159,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "c0dc502b20b238081f43f0417fbfee1bdcede340",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue