openstack
/
charm-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 935 <935@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e143de227233921b12fc5e5e0c6583328f056750
This commit is contained in:
Gerrit User 935 2024-01-03 15:20:13 +00:00 committed by Gerrit Code Review
parent 8defdd19a6
commit 32ff95a63c
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
f352842a602563c018f0592ef083dbb144c95d70
View File

@ -16,6 +16,23 @@
"message": "recheck",
"revId": "f352842a602563c018f0592ef083dbb144c95d70",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "024fafdf_2717a349",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 935
},
"writtenOn": "2024-01-03T15:20:13Z",
"side": 1,
"message": "As much as I don\u0027t like the security implications of a global set of credentials to access ceph in an openstack deployment I don\u0027t see any other way of making this work.\n\n+1 on approach - the documentation build failure needs a fix before we can merge.\n\n/home/zuul/src/opendev.org/openstack/charm-specs/doc/source/specs/2023.2/approved/unify-ceph-nova-compute-credentials.rst:document isn\u0027t included in any toctree",
"revId": "f352842a602563c018f0592ef083dbb144c95d70",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}