openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Backport-Candidate-1 Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 10058 <10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 44745dbb6357827ee4b1edcf3e208cbdd975b721
Label: Backport-Candidate=-1, 6496387b7697a339922a27f370d7988e2cfb969b
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}
This commit is contained in:
Gerrit User 10058 2023-12-07 14:42:27 +00:00 committed by Gerrit Code Review
parent 8c57341f54
commit 159e5fc714
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
15d652e924286025214cead3bbdbc9d66f8bb186 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "8a845f3a_be205125",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10058
},
"writtenOn": "2023-12-07T14:42:27Z",
"side": 1,
"message": "As I mentioned concerns before, backporting this to brances \u003c1.7 might cause regression problems which seems to be the case here. So, Im -1 this until we figure out what to do with this.\n\n\"TypeError: \u0027NoneType\u0027 object is not subscriptable\"",
"revId": "15d652e924286025214cead3bbdbc9d66f8bb186",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}