openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review+1

(2 comments)

Patch-set: 8
Reviewer: Gerrit User 27944 <27944@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 0935118060f1e5c5409824861c2685120b5e8dc6
Attention: {"person_ident":"Gerrit User 27944 \u003c27944@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_27944\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32363 \u003c32363@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_27944\u003e replied on the change"}
This commit is contained in:
Gerrit User 27944 2023-12-07 20:48:48 +00:00 committed by Gerrit Code Review
parent 55c77d3f7a
commit 237578dae3
2 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
2baa81c6ed54a4bd945b38f3c8da5d765f157050
View File

@ -97,6 +97,30 @@
},
"revId": "2baa81c6ed54a4bd945b38f3c8da5d765f157050",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "289ddc00_56705985",
"filename": "unit_tests/test_reactive_vault_handlers.py",
"patchSetId": 6
},
"lineNbr": 572,
"author": {
"id": 27944
},
"writtenOn": "2023-12-07T20:48:48Z",
"side": 1,
"message": "Done",
"parentUuid": "3e04739e_98b8b5c3",
"range": {
"startLine": 552,
"startChar": 4,
"endLine": 572,
"endChar": 45
},
"revId": "2baa81c6ed54a4bd945b38f3c8da5d765f157050",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

17
4856a068e8f3b9701671fb32a048a81833c17512
View File

@ -50,6 +50,23 @@
"message": "recheck",
"revId": "4856a068e8f3b9701671fb32a048a81833c17512",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1fcb0b21_8031328f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 8
},
"lineNbr": 0,
"author": {
"id": 27944
},
"writtenOn": "2023-12-07T20:48:48Z",
"side": 1,
"message": "lgtm, CI passes and the commit is identical to the one already in master",
"revId": "4856a068e8f3b9701671fb32a048a81833c17512",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}