openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 10058 <10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 5b1f38d57de03fd3e366df9d01a0c9366d033a45
This commit is contained in:
Gerrit User 10058 2023-11-23 16:38:24 +00:00 committed by Gerrit Code Review
parent 00755b271d
commit 37076ede34
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
56ca825332964a58961f6df3a1ca52df394f2d2c
View File

@ -51,6 +51,23 @@
"parentUuid": "18599c5d_4ba858ef",
"revId": "56ca825332964a58961f6df3a1ca52df394f2d2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "943419f6_b2804411",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10058
},
"writtenOn": "2023-11-23T16:38:24Z",
"side": 1,
"message": "I\u0027m +1ing this one even though it seems very risky for a stable branch. There were many regressions for this and it\u0027s hard for to tell for sure that this one will not bring any more. But, given that this affects many customers I still believe that the benefits outweights that risk.",
"revId": "56ca825332964a58961f6df3a1ca52df394f2d2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}