openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(3 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 31503 \u003c31503@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31503\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31503\u003e replied on the change"}
This commit is contained in:
Gerrit User 31503 2023-11-12 22:58:04 +00:00 committed by Gerrit Code Review
parent 6c7ead203a
commit 56a373726d
2 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
0c2d57238d6cf3654b6ec21f6f8be8244ab03454
View File

@ -16,6 +16,23 @@
"message": "LGTM\ncharm-recheck",
"revId": "0c2d57238d6cf3654b6ec21f6f8be8244ab03454",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4b7003ed_c8b1dfdd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 31503
},
"writtenOn": "2023-11-12T22:58:04Z",
"side": 1,
"message": "recheck",
"revId": "0c2d57238d6cf3654b6ec21f6f8be8244ab03454",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

48
3fdec0b728f54262e28f9732c4811b403bf949cb
View File

@ -108,6 +108,30 @@
"revId": "3fdec0b728f54262e28f9732c4811b403bf949cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9bc68a50_69294415",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 9
},
"lineNbr": 143,
"author": {
"id": 31503
},
"writtenOn": "2023-11-12T22:58:04Z",
"side": 1,
"message": "Done",
"parentUuid": "a09cd150_dcbe021d",
"range": {
"startLine": 141,
"startChar": 0,
"endLine": 143,
"endChar": 45
},
"revId": "3fdec0b728f54262e28f9732c4811b403bf949cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -130,6 +154,30 @@
},
"revId": "3fdec0b728f54262e28f9732c4811b403bf949cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5eae96ae_4d242ceb",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 9
},
"lineNbr": 163,
"author": {
"id": 31503
},
"writtenOn": "2023-11-12T22:58:04Z",
"side": 1,
"message": "Done",
"parentUuid": "90b2ae83_61e85b79",
"range": {
"startLine": 161,
"startChar": 11,
"endLine": 163,
"endChar": 45
},
"revId": "3fdec0b728f54262e28f9732c4811b403bf949cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}