openstack
/
charm-vault
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(5 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 31503 \u003c31503@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31503\u003e replied on the change"}
This commit is contained in:
Gerrit User 31503 2023-10-17 18:42:51 +00:00 committed by Gerrit Code Review
parent bf4fede2a8
commit 833d058a88
2 changed files with 120 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
96f98b33188ed156f01e98b2560c5240e38bee4f
View File

@ -40,6 +40,30 @@
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6feefa9d_43d503e8",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 5
},
"lineNbr": 115,
"author": {
"id": 31503
},
"writtenOn": "2023-10-17T18:42:51Z",
"side": 1,
"message": "Done",
"parentUuid": "0a5f9264_e9d56881",
"range": {
"startLine": 115,
"startChar": 5,
"endLine": 115,
"endChar": 17
},
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +87,30 @@
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5c8412c2_7f93270c",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 5
},
"lineNbr": 126,
"author": {
"id": 31503
},
"writtenOn": "2023-10-17T18:42:51Z",
"side": 1,
"message": "Done",
"parentUuid": "aff128d5_f8d0c53c",
"range": {
"startLine": 126,
"startChar": 0,
"endLine": 126,
"endChar": 0
},
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +134,30 @@
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5e10e53c_44da5c6d",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 5
},
"lineNbr": 145,
"author": {
"id": 31503
},
"writtenOn": "2023-10-17T18:42:51Z",
"side": 1,
"message": "Done",
"parentUuid": "818b69b6_981fe612",
"range": {
"startLine": 135,
"startChar": 8,
"endLine": 145,
"endChar": 45
},
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -108,6 +180,30 @@
},
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "56516b43_6a3d6f08",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 5
},
"lineNbr": 146,
"author": {
"id": 31503
},
"writtenOn": "2023-10-17T18:42:51Z",
"side": 1,
"message": "Done",
"parentUuid": "fc528f9b_d936a84f",
"range": {
"startLine": 146,
"startChar": 1,
"endLine": 146,
"endChar": 2
},
"revId": "96f98b33188ed156f01e98b2560c5240e38bee4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
de176c8506d8383f6198a6008e81dd98977a79b4
View File

@ -22,6 +22,30 @@
},
"revId": "de176c8506d8383f6198a6008e81dd98977a79b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8cace8e3_ec1259dc",
"filename": "src/lib/charm/vault_pki.py",
"patchSetId": 6
},
"lineNbr": 159,
"author": {
"id": 31503
},
"writtenOn": "2023-10-17T18:42:51Z",
"side": 1,
"message": "on vault 1.8 we are not able to use the generate_intermediate after all, so this is not relevant",
"parentUuid": "fb952f1d_f54d96f7",
"range": {
"startLine": 157,
"startChar": 0,
"endLine": 159,
"endChar": 73
},
"revId": "de176c8506d8383f6198a6008e81dd98977a79b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}