Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2

b2d1dddc27f8f71382a2ff68f56470b51dcdf986

@@ -40,6 +40,29 @@
       "revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "93a24837_71b28a0a",
+        "filename": "src/actions.yaml",
+        "patchSetId": 2
+      },
+      "lineNbr": 110,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2024-01-05T13:00:49Z",
+      "side": 1,
+      "message": "Could this not be \"crl-distribution-point\" to more closely match the parameter in the vault call?",
+      "range": {
+        "startLine": 110,
+        "startChar": 4,
+        "endLine": 110,
+        "endChar": 18
+      },
+      "revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -79,6 +102,29 @@
       "message": "need to add the :param ...: and :type ...: into the function\u0027s docstring to explain what the parameter is for, and the type s allowed.  Note the existing ones are wrong.\n\nIn this case it should be:\n\n    :pararm crl_dist_point: explain what it is\n    :type crl_dist_point: Optional[str]\n    \nBonus points if you update the existing types to include `Optional[\u003ctype\u003e]` for the optional parameters!",
       "revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d90ea1e8_e2babb72",
+        "filename": "src/lib/charm/vault_pki.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 206,
+      "author": {
+        "id": 20870
+      },
+      "writtenOn": "2024-01-05T13:00:49Z",
+      "side": 1,
+      "message": "This param would probably be better named as \"crl_distribution_point\" to more closely match the calling param in set_urls.\n\nAlso is there a reason it is singular?  The set_urls() function appears to be expecting a list of urls?",
+      "range": {
+        "startLine": 206,
+        "startChar": 41,
+        "endLine": 206,
+        "endChar": 42
+      },
+      "revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }