Update patch set 6

Patch Set 6: Code-Review-1

(1 comment)

Patch-set: 6
Reviewer: Gerrit User 10058 <10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 2b3c35690c5c23e93d96f439586f1049acad08ab
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}

de176c8506d8383f6198a6008e81dd98977a79b4

@@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "fb952f1d_f54d96f7",
+        "filename": "src/lib/charm/vault_pki.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 159,
+      "author": {
+        "id": 10058
+      },
+      "writtenOn": "2023-10-17T17:42:22Z",
+      "side": 1,
+      "message": "If you only get the \u0027warnings\u0027, you might loose the root cause if it is listed in the \u0027errors\u0027 field. So, after having some thoughs about this, I believe that we should print any stack trace errors along with the data return it from vault. That is because, case we need to debug this, the filters you are adding here will obscate the real reason of the problem or did they use that might help to solve it.",
+      "range": {
+        "startLine": 157,
+        "startChar": 0,
+        "endLine": 159,
+        "endChar": 73
+      },
+      "revId": "de176c8506d8383f6198a6008e81dd98977a79b4",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}